Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Modified example/integration_test/general_test.dart to change the expectation for progressCallbackCounter from equals(2) to greaterThanOrEqualTo(2) in the 'enqueue with progress' test case. This makes the test robust against unexpected intermediate progress updates when the Content-Length is unknown.


PR created automatically by Jules for task 5872473099476310969 started by @781flyingdutchman

The integration test 'enqueue with progress' was flaky because it expected exactly 2 progress updates (0.0 and 1.0) when downloading from google.com (which has no Content-Length). However, under some network conditions, more updates are received. This change relaxes the expectation to be greater than or equal to 2.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@781flyingdutchman 781flyingdutchman marked this pull request as ready for review November 22, 2025 02:38
@781flyingdutchman 781flyingdutchman merged commit 1b43280 into dev Nov 22, 2025
9 checks passed
@781flyingdutchman 781flyingdutchman deleted the fix-flaky-test-enqueue-progress branch November 22, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants